Listen for an event to allow refreshing the ellipsis #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of the directive can now trigger the 'dibari:refresh-ellipsis'
event to refresh the ellipsis state. This can be used to implement
expand/collapse functionality just by changing the element's height and
triggering the event: $scope.$broadcast('dibari:refresh-ellipsis');
MauMaGau
added a commit
that referenced
this pull request
Jan 4, 2016
Listen for an event to allow refreshing the ellipsis
|
Hi Georgi, This is a very good addition. One questions though - does this mean if there are multiple ellipsis elements in a page, all of them will rebuild themselves once you do the broadcast? Or is there a way to tell a particular ellipsis element to rebuild using your solution? Thanks, |
@gstoyanov - can you help with an example on how to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added an event that allows users of the directive to tell it if it needs to rebuild. This makes it easy to implement collapse/expand functionality by just toggling a class and triggering the event:
$scope.$broadcast('dibari:refresh-ellipsis');. Maybe this also solves issue #2?Best,
Georgi