Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

implementation of uniform data format for IDA #111

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

AsjadLFC
Copy link
Collaborator

Implementation of uniform dataset format with SPARQL endpoint created. Uploading of files done as general which converts them into turtle format. shows the available databases to the user as well. Integration is also completed with IDA.

Maqbool ur Rahim khan and others added 30 commits November 17, 2018 18:58
SParQL endpoint created, with output in JSON format
Alternate approach for turtle datasets
validation with file extension and file mime type added for dataset
@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #111 into master will decrease coverage by 2.03%.
The diff coverage is 8.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
- Coverage      39.6%   37.56%   -2.04%     
- Complexity      132      134       +2     
============================================
  Files            48       53       +5     
  Lines          1212     1291      +79     
  Branches        134      140       +6     
============================================
+ Hits            480      485       +5     
- Misses          704      778      +74     
  Partials         28       28
Impacted Files Coverage Δ Complexity Δ
...a-ws/src/main/java/upb/ida/util/UploadManager.java 0% <0%> (ø) 0 <0> (?)
...src/main/java/upb/ida/provider/LoadDsMetadata.java 5.55% <0%> (-2.14%) 1 <0> (ø)
...-ws/src/main/java/upb/ida/constant/IDALiteral.java 0% <0%> (ø) 0 <0> (?)
ida-ws/src/main/java/upb/ida/util/FileUtil.java 32.85% <0%> (-0.97%) 6 <0> (ø)
...src/main/java/upb/ida/util/FileConversionUtil.java 0% <0%> (ø) 0 <0> (?)
.../java/upb/ida/provider/RiveScriptBeanProvider.java 100% <100%> (ø) 2 <0> (ø) ⬇️
.../main/java/upb/ida/rest/MessageRestController.java 25.64% <100%> (-27.31%) 2 <0> (ø)
...ws/src/main/java/upb/ida/provider/ShowDataset.java 11.11% <11.11%> (ø) 1 <1> (?)
.../src/main/java/upb/ida/provider/UploadDataset.java 9.09% <9.09%> (ø) 1 <1> (?)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc07ba...feefefc. Read the comment docs.

@maqboolkhan
Copy link
Collaborator

@AsjadLFC After recent commits by yo, problem of wrong message by UI has been solved itself 👍

cc @nikit91

@AsjadLFC
Copy link
Collaborator Author

@nikit91 the problems were resolved

@nikit-srivastava
Copy link
Member

@AsjadLFC please look into the codacy issues

@AsjadLFC
Copy link
Collaborator Author

@Nikit codacy issues taken care of

@nikit-srivastava
Copy link
Member

closing and reopening issue because of codacy problem

@nikit-srivastava
Copy link
Member

for some reason codacy is not analyzing this pull request anymore

@AsjadLFC are you using your uni email to push the commits or is it personal one?

@AsjadLFC
Copy link
Collaborator Author

@nikit91 university mail

@nikit-srivastava
Copy link
Member

@AsjadLFC from what I can see, your commits are not linked to your github account, try configuring your local git author and email again

@maqboolkhan
Copy link
Collaborator

@AsjadLFC kindly resolve coflicts

@maqboolkhan
Copy link
Collaborator

@AsjadLFC kindly check and comment here if everything is still working fine
Thanks then ill merge this PR

@maqboolkhan maqboolkhan changed the title implementation and integration of udf implementation of uniform data format for IDA Apr 18, 2019
@maqboolkhan
Copy link
Collaborator

changed its title as there is alot to do with its integration with IDA

@AsjadLFC
Copy link
Collaborator Author

Tasks:

  • XML to RDF
  • CSV to RDF
  • rivescripts for show and upload datasets
  • file upload
  • endpoint for query made

tested after integration also

Copy link
Collaborator

@maqboolkhan maqboolkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AsjadLFC i added some comments for myself. I will fix them and merge it

And @Cortys can you please also review it?
Thanks

Model m = ModelFactory.createDefaultModel();
// (TODO) http://example.com must not be fixed
m.read(inputStream, "http://example.com", "csv");
m.setNsPrefix("test", "http://example.com#");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this TODO

const formData = new FormData();
formData.append('file', this.file);
formData.append('fileName', this.data.datasetName);
this._http.post('http://localhost:8080/ida-ws/message/file', formData).subscribe(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This post method should be in some kind of service may be rest.service.ts

}

uploadDataset() {
console.log(this.data.datasetName);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log

@maqboolkhan maqboolkhan requested a review from Cortys April 22, 2019 18:22
@maqboolkhan
Copy link
Collaborator

This PR is on hold

@maqboolkhan maqboolkhan closed this Jul 1, 2019
@maqboolkhan maqboolkhan reopened this Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants