-
Notifications
You must be signed in to change notification settings - Fork 4
implementation of uniform data format for IDA #111
base: master
Are you sure you want to change the base?
Conversation
SParQL endpoint created, with output in JSON format
Basic RDF SPARQL server
CSV to RDF adapter completed
…iable and reusable
File upload conversion facility
Alternate approach for turtle datasets
validation with file extension and file mime type added for dataset
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
============================================
- Coverage 39.6% 37.56% -2.04%
- Complexity 132 134 +2
============================================
Files 48 53 +5
Lines 1212 1291 +79
Branches 134 140 +6
============================================
+ Hits 480 485 +5
- Misses 704 778 +74
Partials 28 28
Continue to review full report at Codecov.
|
@AsjadLFC After recent commits by yo, problem of wrong message by UI has been solved itself 👍 cc @nikit91 |
@nikit91 the problems were resolved |
@AsjadLFC please look into the codacy issues |
@Nikit codacy issues taken care of |
closing and reopening issue because of codacy problem |
for some reason codacy is not analyzing this pull request anymore @AsjadLFC are you using your uni email to push the commits or is it personal one? |
@nikit91 university mail |
@AsjadLFC from what I can see, your commits are not linked to your github account, try configuring your local git author and email again |
@AsjadLFC kindly resolve coflicts |
@AsjadLFC kindly check and comment here if everything is still working fine |
changed its title as there is alot to do with its integration with IDA |
Tasks:
tested after integration also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Model m = ModelFactory.createDefaultModel(); | ||
// (TODO) http://example.com must not be fixed | ||
m.read(inputStream, "http://example.com", "csv"); | ||
m.setNsPrefix("test", "http://example.com#"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix this TODO
const formData = new FormData(); | ||
formData.append('file', this.file); | ||
formData.append('fileName', this.data.datasetName); | ||
this._http.post('http://localhost:8080/ida-ws/message/file', formData).subscribe( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This post
method should be in some kind of service may be rest.service.ts
} | ||
|
||
uploadDataset() { | ||
console.log(this.data.datasetName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove console.log
This PR is on hold |
Implementation of uniform dataset format with SPARQL endpoint created. Uploading of files done as general which converts them into turtle format. shows the available databases to the user as well. Integration is also completed with IDA.