This repository has been archived by the owner on Jul 26, 2023. It is now read-only.
Soldier timeline #172
Open
Soldier timeline #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
============================================
+ Coverage 48.35% 49.75% +1.39%
- Complexity 202 233 +31
============================================
Files 53 55 +2
Lines 1518 1807 +289
Branches 175 237 +62
============================================
+ Hits 734 899 +165
- Misses 735 823 +88
- Partials 49 85 +36
Continue to review full report at Codecov.
|
RahulSherikar
force-pushed
the
Soldier_Timeline_Viz
branch
from
09f259b
to
faf175d
Compare
nikit-srivastava
suggested changes
Jan 16, 2020
|
|
||
| @Component | ||
| public class SoldierTimeLine { | ||
| private final String PREFIXES = "PREFIX datagraph: <http://127.0.0.1:3030/ssfuehrer/data/data>\n" + |
There was a problem hiding this comment.
Check for prefixes in the constants file, add if not there already. Also, use StringBuilder instead.
| this.allDatesOfDecoration.push(key) | ||
| } | ||
|
|
||
| for (const key in this.soldierData.dates) { |
| ], | ||
| imports: [ | ||
| BrowserModule, | ||
| BrowserAnimationsModule, | ||
| FormsModule, | ||
| ReactiveFormsModule, |
There was a problem hiding this comment.
I don't think this component is needed
| import java.util.*; | ||
|
|
||
| @Component | ||
| public class SoldierTimeLine { |
There was a problem hiding this comment.
Missing comments (javadocs)
| soldierDataMap.put("regimentInfo__" + j, tempStringVsStringMap); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Method level comments are missing
Comment on lines
+349
to
+355
| /*JSONObject childObj = new JSONObject(); | ||
| JSONArray childLst = new JSONArray(); | ||
| for (String k : childRef.keySet()) { | ||
| childObj.put(k, childRef.get(k)); | ||
| } | ||
| childLst.add(childObj); | ||
| map.put(key, childLst.toString());*/ |
|
|
||
|
|
||
| } | ||
| package upb.ida.provider; |
There was a problem hiding this comment.
try resolving whitespace issue. It is hard to track changes if everything shows as changed
| package upb.ida.rest; |
There was a problem hiding this comment.
try resolving whitespace issue
| @Test | ||
| public void sendmessagetestPos() throws Exception { | ||
| ResponseBean responseBean; | ||
| responseBean = mrc.sendmessage("I would like a force directed graph visualization for the current table", "1", "citydistancetest.csv", "city"); | ||
| responseBean = mrc.sendmessage("Source node is city1", "1", "citydistancetest.csv", "city"); | ||
| responseBean = mrc.sendmessage("Target node is city2", "1", "citydistancetest.csv", "city"); | ||
| responseBean = mrc.sendmessage("Strength between the nodes should be represented by distance", "1", "citydistancetest.csv", "city"); | ||
|
|
||
|
|
||
| System.out.println(responseBean.getPayload().get("fdgData")); |
There was a problem hiding this comment.
nothing should be printed to console
| @Test | ||
| public void sendmessagetestExt() throws Exception { | ||
| ResponseBean responseBean; | ||
| responseBean = mrc.sendmessage("I would like a force directed graph visualization for the current table", "1", "citydistancetest.csv", "city"); | ||
| responseBean = mrc.sendmessage("Source node is city1", "1", "citydistancetest.csv", "city"); | ||
| responseBean = mrc.sendmessage("Target node is city2", "1", "citydistancetest.csv", "city"); | ||
| responseBean = mrc.sendmessage("Strength between the nodes should be represented by distance", "1", "citydistancetest.csv", "city"); | ||
|
|
||
|
|
||
| System.out.println(responseBean.getPayload().get("fdgData")); |
There was a problem hiding this comment.
Please remove sysout statements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.