Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't convert OSM IDs to integer #48

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Don't convert OSM IDs to integer #48

merged 1 commit into from
Jun 26, 2024

Conversation

dieghernan
Copy link
Owner

@dieghernan dieghernan commented Jun 26, 2024

As it may fail on long IDs, close #47

@dieghernan dieghernan added the bug Something isn't working label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (fd259be) to head (e93a8fb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   98.13%   98.14%           
=======================================
  Files          13       13           
  Lines         698      700    +2     
=======================================
+ Hits          685      687    +2     
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dieghernan dieghernan merged commit ab892a3 into main Jun 26, 2024
14 checks passed
@dieghernan dieghernan deleted the asnum branch June 26, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long OSM IDs cause integer issue and NA.
1 participant