Patch: CI + gh fixes #148
Open
Patch: CI + gh fixes #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it slipped out of my mind... |
no prob! I am cumulating it with other stuff anyways! |
|
this one is good to go, once reviewed I would propose to do a small patch due to the breaking #147 @DamienGilliard @eleniv3d . cheers! |
DamienGilliard
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Thanks @9and3. Only left a small question about compatibility of python versions, but otherwise all good with me
| @@ -9,7 +9,7 @@ diffCheck/df_joint_detector.py | |||
| diffCheck/df_transformations.py | |||
| diffCheck/df_util.py | |||
| diffCheck/df_visualization.py | |||
| diffCheck/diffcheck_bindings.cp39-win_amd64.pyd | |||
There was a problem hiding this comment.
Small question, could this python 3.12 bump cause problem with the python 3.9 Rhino uses in terms of compatibility ? I suppose not but you know better...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple patch to solve a couple of problems, notably #147 which is urgent, also a small hicup in the cmake ctesting running on ci.
fixes:
1. Error begin run: cannot import name 'diffcheck_bindings' from partially initialized module 'diffCheck' (most likely due to a circular import) (c:\users\localuser\diffcheck\src\gh\diffcheck\diffCheck\__init__.py) [9:1]