feat: implement meeting detection and Obsidian note creation #370
Conversation
|
@onyedikachi-david is attempting to deploy a commit to the Prologe Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented comprehensive meeting detection and Obsidian note integration system with real-time screen/audio activity analysis and AI-powered relationship intelligence.
- Added
use-meeting-detection.tshook to monitor Zoom/Meet/Teams activity usingstreamVisionAPI with configurable app detection - Implemented
/api/intelligence/route.tsfor relationship analysis using Ollama LLM, generating contact insights and Mermaid graphs - Created
/api/log/route.tsfor automated work log generation with customizable prompts and Obsidian table format sync - Added
MeetingNotificationcomponent with proper accessibility and responsive design for meeting alerts - Improved error handling and deep linking in
ObsidianSettingscomponent with vault path validation and intelligence analysis UI
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
54 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile
| } catch (error) { | ||
| console.error('Failed to open Obsidian:', error); | ||
| } |
There was a problem hiding this comment.
style: Error handling only logs to console. Should show error to user via toast/notification
| useEffect(() => { | ||
| if (isInMeeting) { | ||
| setShowNotification(true); | ||
| } | ||
| }, [isInMeeting]); |
There was a problem hiding this comment.
logic: No logic to handle when meeting ends - notification could stay visible if state updates fail
| useEffect(() => { | |
| if (isInMeeting) { | |
| setShowNotification(true); | |
| } | |
| }, [isInMeeting]); | |
| useEffect(() => { | |
| setShowNotification(isInMeeting); | |
| }, [isInMeeting]); |
| const obsidianUrl = `obsidian://new?vault=YourVault&name=${encodedTitle}`; | ||
|
|
||
| // Open the URL | ||
| window.open(obsidianUrl, '_blank'); |
There was a problem hiding this comment.
style: Check if window.open() returned null (blocked by popup blocker) and handle that case
| <button | ||
| onClick={onDismiss} | ||
| className="text-gray-400 hover:text-gray-500" | ||
| aria-label="Close" | ||
| > |
There was a problem hiding this comment.
syntax: Close button should have type='button' to prevent form submission in parent forms
| <button | |
| onClick={onDismiss} | |
| className="text-gray-400 hover:text-gray-500" | |
| aria-label="Close" | |
| > | |
| <button | |
| onClick={onDismiss} | |
| className="text-gray-400 hover:text-gray-500" | |
| aria-label="Close" | |
| type="button" | |
| > |
| return () => { | ||
| abortController.abort(); | ||
| }; | ||
| }, [meetingState.isInMeeting]); |
There was a problem hiding this comment.
logic: dependency on meetingState.isInMeeting will cause effect to re-run and create new streamVision subscription on every state change
| }, [meetingState.isInMeeting]); | |
| }, []); // Remove dependency on meetingState to prevent re-subscriptions |
| const isMeetingApp = MEETING_APPS.some(app => | ||
| url?.includes(app) || appName?.toLowerCase().includes(app.split('.')[0]) | ||
| ); |
There was a problem hiding this comment.
style: meeting detection logic may trigger false positives if app/URL contains meeting app name as substring (e.g. 'zoom' in 'zoomable')
| if (isMeetingApp && !meetingState.isInMeeting) { | ||
| // User just entered a meeting | ||
| setMeetingState({ | ||
| isInMeeting: true, | ||
| appName: appName || url || 'Unknown Meeting App', | ||
| startTime: new Date(), | ||
| }); | ||
| } else if (!isMeetingApp && meetingState.isInMeeting) { |
There was a problem hiding this comment.
style: consider debouncing state updates to prevent rapid changes when switching between windows
|
Please show screen-recording of working workflow. |
|
closing because no follow up |
|
Could you please reopen. I'm actually on it. Demoing in a bit. Apologies for the delay. @benjaminshafii |
/claim #366
Fixes: #366