-
Notifications
You must be signed in to change notification settings - Fork 50
setting start and end clips #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah at the moment its buggy, its works on imageClip, u can extend your text or video clip and copy paste from ImageClip, or u can use offset at the moment but i am pretty sure Konstantin will fix it very shortly 😂 |
I was reviewing code, ImageClip is extend of Clip and VideoClip is extend of MediaClip and MediaClip is extend of Clip, I am not sure but I think also image suppose to be part of MediaClip, because only biggest difference both of them is Video has a audio element and image is not, but if the image is animated gif, it will have frames, we will need offset values and why we are not able to put a Caption on Image? |
no worry, i might remove the use of track, or handling in the back for users to ensure ux
from the guide // proper `stacked` strategy would be helpful
composition.createTrack('video', { stacked: Boolean }); |
you can't, the problem is layering 😅, you can't layer clip with (z)index so to layer, we need to use |
Why u need a z-index if 2 clips are in same tracks? zindex are for html elements but clips are on the canvas, if you wanna debug how the track and clips are on the canvas, u can use pixie devtool, https://pixijs.io/devtools/ |
If you make it work, its good. But in general u dont need 3rd party library, actually its simple. But do not forget there is happing in canvas, so actually there is no zindex. |
From the docs, but not actual the case @k9p5 If clips overlap, Diffusion Studio will automatically adjust the start/stop times or |
And personal suggestion, as i understand u re using vue, if u re using vue devtool, make compotison as a shallowRef and from vue devtool u can understand, debug more easily. |
yeah kind a complicated but I think start must have to key for create starting position, |
ps another nice timeline, u re good with timelines :) |
Over the last couple of weeks I've been working on a timeline component and got it to work quite reliably using the current version. For trimming I used: clip.start = <start frames> // or clip.set({ start: <start frames> })
clip.stop = <stop frames> To move the clip along the x axis within the same track: clip.offsetBy(offset); And to move it into another track: track.add(clip.detach().offsetBy(offset)); Hope that helps. I will make my timeline open source asap. |
I also made use of |
The reason it's referred to as start/stop with media clips is to provide a universal way to trim clips, regardless of their type. In addition, I plan to introduce a What do you think of this approach? |
Sorry I had miss understood, I was thinking offset was for trimming, |
Z-index is controlled via |
|
Yeah now I am reading docs again, I had some miss understoodies, (ps. I dont have a timeline yet :) I didnt have change to try them) |
Should we implement This would create a consistent API across different media types and simplify the trimming logic. What do you think? |
for me sound more easy to understand |
Then we can also replace |
watch out with Backward Compatibility :) |
I will move from |
And one last suggestion, |
What do you think? Core dev (view) |
Start and end method is really useful for tracking clips on the timeline etc,
but unfortunately start and end is not working on VideoClip, works with ImageClip and I didn't try with other clips yet,
Can we make work with all, after we set to start time also we can delay it with offset as well but following them with start end stop is more easy to track.
p.s. please dont hate me
The text was updated successfully, but these errors were encountered: