Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket: Sends NO CARRIER when _not_ configured as modem #118

Open
knghtbrd opened this issue Apr 18, 2022 · 0 comments · May be fixed by #120
Open

Socket: Sends NO CARRIER when _not_ configured as modem #118

knghtbrd opened this issue Apr 18, 2022 · 0 comments · May be fixed by #120

Comments

@knghtbrd
Copy link

Having a little trouble using GSPlus to debug ADTPro type stuff because when the ADTPro server disconnects from the socket, it still acts modemy with simple socket emulation mode, sending a NO CARRIER, etc.

I believe the problem is in scc_socket_close in scc_socket_driver.c, around line 335. Should that line be conditional upon g_serial_modem[port] perhaps? It certainly looks to me like that's all that's necessary. Making it conditional seems to fix GSplus as tested using ProTERM.
knghtbrd added a commit to knghtbrd/gsplus that referenced this issue Apr 20, 2022
@knghtbrd
Socket driver isn't modem
92ff3fa 
The socket driver erroneously acts like a modem on disconnect
unconditionally, even when told not to. Correct that (fixes
digarok#118)
@knghtbrd knghtbrd linked a pull request Apr 20, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix serial socket, minor cleanups knghtbrd/gsplus
1 participant
@knghtbrd