Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page links in mobile reading view #84

Open
dvglc opened this issue Mar 3, 2020 · 1 comment
Open

Fix page links in mobile reading view #84

dvglc opened this issue Mar 3, 2020 · 1 comment
Assignees
Labels
bug Something isn't working needs-discussion Issue needs to be discussed with the scholarly team reading-view
Milestone

Comments

@dvglc
Copy link
Contributor

dvglc commented Mar 3, 2020

In the mobile version of the reading view, page links tend to slide off the left border of the screen.

@dvglc dvglc added the bug Something isn't working label Mar 3, 2020
@dvglc dvglc added this to the v2.0 milestone Mar 3, 2020
@dvglc dvglc self-assigned this Mar 3, 2020
@digicademy digicademy deleted a comment from awagner-mainz Mar 3, 2020
@digicademy digicademy deleted a comment from awagner-mainz Mar 3, 2020
@dvglc dvglc modified the milestones: v2.0, v2.0.1 Mar 9, 2020
@dvglc
Copy link
Contributor Author

dvglc commented Mar 9, 2020

I think this is a somewhat larger design issue, since the question ist how to represent page anchors somehow in the text (and not to the left of the text, as is currently the case). A possible solution might be special symbols (such as pipes "|") that would function as links on click, but I'm not sure if those page anchors would be visible enough.

In the very short term, we could simply hide links with (very) small screens. The Mirador view is almost unusable with very small screens anyway, so I think hiding it altogether wouldn't be a problem.

@dvglc dvglc added the needs-discussion Issue needs to be discussed with the scholarly team label Mar 9, 2020
@awagner-mainz awagner-mainz modified the milestones: v2.0.1, v2.1 Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-discussion Issue needs to be discussed with the scholarly team reading-view
Projects
None yet
Development

No branches or pull requests

2 participants