Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failure codes when adding a server #925

Closed
EvanHahn opened this issue Oct 21, 2024 · 1 comment
Closed

Add failure codes when adding a server #925

EvanHahn opened this issue Oct 21, 2024 · 1 comment
Assignees
@EvanHahn
Labels
Project: Community Server v1

Comments

@EvanHahn
Copy link
Contributor

EvanHahn commented Oct 21, 2024 •
edited
Loading

This may require work in the server module.

The frontend should be able to disambiguate between the following errors based on their designs:

  • Network error
  • Server gave an unexpected response
  • Server already in use

This probably means attaching a property like code to the error in the rejection from addServerPeer.
@EvanHahn EvanHahn self-assigned this Oct 21, 2024
EvanHahn added a commit that referenced this issue Oct 21, 2024
@EvanHahn
Return some error codes when adding peers
ae24889 
Partly addresses #925. Not finished.
EvanHahn added a commit that referenced this issue Oct 21, 2024
@EvanHahn
Add some failure codes when adding a server
fc1ad52 
Partly addresses #925.
@EvanHahn
Copy link
Contributor Author

EvanHahn commented Nov 7, 2024

Done in ae24889, fc1ad52, #955, and digidem/comapeo-cloud#33.

@EvanHahn EvanHahn closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
Project: Community Server v1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EvanHahn