You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Managing draft observations is a critical part of the app, and a part that is really important to get right. Currently the logic for managing a draft observation is split between two hooks useDraftObservation and usePersistedDraftObservation. Some properties from one hook are the same as the other, and some are different. We also return a hook from a hook, which is confusing.
Cleaning up and simplifying this code should make it easier to maintain this part of the app and to write unit tests for the important logic around updating presets and saving photos and audio.
The text was updated successfully, but these errors were encountered:
gregor worked on an initial implementation of revised useDraftObservation() hook that is basically done (no tests yet).
gregor worked on an adjacent item around updating the observation draft location in the background, which should remove some logic that's being done in the app
we all tried to experiment with the integration in certain parts of the app. gregor + erik looked into Create + Edit observation screens. andrew updated the CameraView and anything that consumes it. our explorations lives on the chore/draft-observation-hooks branch
what's left to do:
write tests for the revised useDraftObservation() hook + draft observation location updater
integrate new hook into the app without drastically removing unnecessary work that exists. estimate: 2 days
follow-up: remove the things that are no longer needed because of the new hook
follow-up: addressing bugs we'll find along the way during integration. these should be reported separately and addressed separately.
Managing draft observations is a critical part of the app, and a part that is really important to get right. Currently the logic for managing a draft observation is split between two hooks
useDraftObservation
andusePersistedDraftObservation
. Some properties from one hook are the same as the other, and some are different. We also return a hook from a hook, which is confusing.Cleaning up and simplifying this code should make it easier to maintain this part of the app and to write unit tests for the important logic around updating presets and saving photos and audio.
The text was updated successfully, but these errors were encountered: