From 6d7648866c9648abe8477309da965c3b608710d7 Mon Sep 17 00:00:00 2001 From: Luis Otavio Date: Thu, 23 Jan 2025 08:57:13 -0300 Subject: [PATCH] Remove redundant service readiness checks from deployment workflow --- .github/workflows/stacks.yml | 39 ------------------------------------ 1 file changed, 39 deletions(-) diff --git a/.github/workflows/stacks.yml b/.github/workflows/stacks.yml index 123565f..c20908d 100644 --- a/.github/workflows/stacks.yml +++ b/.github/workflows/stacks.yml @@ -1,9 +1,6 @@ name: Deployment Stacks on: - push: - paths: - - 'deploy/**' pull_request: paths: - 'deploy/**' @@ -60,42 +57,6 @@ jobs: fi done - - name: Wait for services to be ready - run: | - while IFS= read -r dir; do - service_name=$(basename "$dir" | sed 's/-stack//') - echo "Waiting for $service_name..." - - # Get port from config - port=$(bun run -b --bun ./tooling/scripts/get-port.ts ${service_name}) - - if [ -z "$port" ]; then - echo "No port configured for $service_name, skipping..." - continue - fi - - # Wait for container health check - timeout 120 bash -c "until docker ps --filter name=${service_name} --format '{{.Status}}' | grep -q 'healthy'; do - echo 'Waiting for ${service_name} health check...' - sleep 5 - done" || { - echo "Service $service_name failed to become healthy" - docker logs ${service_name} - exit 1 - } - - # Wait for port to be available - timeout 60 bash -c "until nc -z localhost $port; do - echo 'Waiting for port $port...' - sleep 2 - done" || { - echo "Service $service_name failed to expose port $port" - docker logs ${service_name} - exit 1 - } - - done < $GITHUB_WORKSPACE/deploy_dirs.txt - - name: Test endpoints run: | while IFS= read -r dir; do