-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission 427, Politycki/Sonder #29
Conversation
Co-Authored-By: Bastian Politycki <[email protected]> Co-Authored-By: Christian Sonder <[email protected]>
WalkthroughThe changes encompass the introduction of a new YAML configuration for a manuscript, a comprehensive manuscript file that outlines modern software engineering practices within digital humanities, and the creation of a bibliographic reference file. These updates collectively aim to enhance project organization, improve documentation, and ensure sustainable development practices in a long-term research initiative. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
submissions/427/images/schema-pipeline.png
is excluded by!**/*.png
Files selected for processing (3)
- submissions/427/_quarto.yml (1 hunks)
- submissions/427/index.qmd (1 hunks)
- submissions/427/references.bib (1 hunks)
Files skipped from review due to trivial changes (1)
- submissions/427/_quarto.yml
Additional comments not posted (22)
submissions/427/references.bib (16)
2-16
: Entryinformatik_software_2019
looks good.The bibliographic entry is complete and correctly formatted.
18-25
: Entrytext_encoding_initiative_guidelines_2024
looks good.The bibliographic entry is complete and correctly formatted.
27-38
: Entryknuth_literate_1992
looks good.The bibliographic entry is complete and correctly formatted.
40-52
: Entryhaaf_enabling_2016
looks good.The bibliographic entry is complete and correctly formatted.
54-61
: Entrylaw_sources_foundation_of_the_swiss_lawyers_society_collection_2024
looks good.The bibliographic entry is complete and correctly formatted.
63-78
: Entryalsaqqa_agile_2020
looks good.The bibliographic entry is complete and correctly formatted.
80-87
: Entrytext_encoding_initiative_roma_2024
looks good.The bibliographic entry is complete and correctly formatted.
89-98
: Entrypolitycki_tei-xml_2024
looks good.The bibliographic entry is complete and correctly formatted.
100-115
: Entrycarver_survey_2022
looks good.The bibliographic entry is complete and correctly formatted.
117-124
: Entryvan_zundert_what_2018
looks good.The bibliographic entry is complete and correctly formatted.
126-131
: Entryporter_what_2024
looks good.The bibliographic entry is complete and correctly formatted.
133-143
: Entryneuber_digitale_2023
looks good.The bibliographic entry is complete and correctly formatted.
145-151
: Entrychristie_mkdocs_2024
looks good.The bibliographic entry is complete and correctly formatted.
153-160
: Entrylaw_sources_foundation_of_the_swiss_lawyers_society_transkriptionsrichtlinien_2024
looks good.The bibliographic entry is complete and correctly formatted.
162-168
: Entrypreston-werner_semantic_2023
looks good.The bibliographic entry is complete and correctly formatted.
170-180
: Entrymartin_clean_2009
looks good.The bibliographic entry is complete and correctly formatted.
submissions/427/index.qmd (6)
1-30
: Metadata section looks good.The metadata is complete and correctly formatted, with well-specified author details and keywords.
32-46
: Introduction section looks good.The introduction is clear, well-structured, and provides a comprehensive overview of the problem and context.
48-52
: Data as a solid ground section looks good.The section is informative and provides a solid explanation of the role of XML schema in digital scholarly editions.
54-140
: Four modern engineering practices section looks good.The section is well-structured and clearly explains the engineering practices with relevant examples.
142-144
: A brief outlook section looks good.The section is concise and effectively summarizes the benefits and future directions of the project.
146-149
: References section looks good.The section is correctly formatted for automatic reference generation.
Pull request
Proposed changes
Co-Authored-By: Bastian Politycki [email protected]
Co-Authored-By: Christian Sonder [email protected]
Types of changes
Checklist
Co-authored-by: Name <[email protected]>
.Summary by CodeRabbit