Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Album Images not displaying. #694

Open
HarlingtonTigers opened this issue Sep 29, 2024 · 11 comments
Open

Some Album Images not displaying. #694

HarlingtonTigers opened this issue Sep 29, 2024 · 11 comments

Comments

@HarlingtonTigers
Copy link

I am using Preview 34.
I have just noticed a bug. I do not know how long it has been there.

In my database I have 18 albums by Pink Floyd. Only one has the Album artwork displaying. I have not found any others that have this issue but that doesn't mean that these are the only ones.

The issue displays a dopamine square with a small icon in the top left corner. Image attached.
I also attach a fresh log file which has no errors in it.
The albums play fine so it is purely the art that is the issue.

Now I also have Dopamine 2 installed and the album art appears fine in that.

So what could be different between 2 and 3 that causes 17 album art to fail to appear without showing an error.
MAIW_1170
Dopamine.log

@digimezzo
Copy link
Owner

@HarlingtonTigers Could you also add your Dopamine.,db?

@HarlingtonTigers
Copy link
Author

Not a problem. Attached it as a zip.
Incidentally, I did try a complete uninstall and reinstall just in case something was corrupted but still the same problem persists.
Dopamine.zip

@digimezzo
Copy link
Owner

@HarlingtonTigers Thank you. I don't understand what is wrong. Could you zip your %appdata%\Dopamine\Cache\CoverArt folder and attach it here also? I'll allow me to have a look at the cached album art. Also, how are you album grouping settings configured?

image

@HarlingtonTigers
Copy link
Author

No problem at all.
My settings are the same as yours, pic attached.
Covers archived and attached as requested.
MAIW_1171
CoverArt.zip

Let me know if there is anything else that might be useful.

@HarlingtonTigers
Copy link
Author

Further info.
Just been through all of my collection. A total of 24 albums have the error. Seven out of the eight from Kingdom Come are like that as well.

It is weird that only two groups are affected and in each case only one album of each group is OK. I don't know if this will help or not.

@digimezzo
Copy link
Owner

@HarlingtonTigers There are multiple artwork files which re 0 KB:

image

For these albums, are you using embedded or external artwork? If embedded, would you mind sharing one of those albums so I can have a look at the embedded artwork? If not, coudl you have a look at the embedded artwork with a tool like mp3tag?

Thank you.

@HarlingtonTigers
Copy link
Author

They are all embedded.
However to try and solve the issue myself I used mp3tag to extract the images and saved them as Folder.jpg.

Obviously neither worked for me.
As the entire albums are too big to attach I have attached a couple of tracks from an album for each of the two groups. The folder.jpg files are included so you can play around with them if needed.
Let me know if this is not enough.
[1973] The Dark Side Of The Moon.zip
[1988] Kingdom Come.zip

@digimezzo
Copy link
Owner

@HarlingtonTigers Thanks a lot for the files. I can see the embedded cover with mp3tag. It's now clear that Dopamine 3 fails to extract them. It does extract a 0 KB image and due to this it ignores the external folder.jpg image. I'll further debug this.

@HarlingtonTigers
Copy link
Author

Thanks. Let me know if you need anything else.

@digimezzo
Copy link
Owner

digimezzo commented Sep 30, 2024

@HarlingtonTigers I've done some debugging and could not resolve this issue myself. The libraries that Dopamine 3 uses for decoding the image files, do not seem to support the format of the cover art for those specific files. I don't know the internal structure of image files enough, but I suspect that there is some slightly non-standard header, or a missing header in those files, which cause the libraries to flip. Two strange things I noticed:

  • Other programs have no trouble with these images (e.g. mp3tag, Paint.net, Gimp, Windows 11 Photos, even Dopamine 2.
  • Your files can be fixed easily by opening them in mp3tag and doing the following:
    • right-click on the cover image
    • choose Adjust cover
    • select PNG of JPG, then press OK
    • then save the file

From then on, they'll be read correctly by Dopamine

For now I don't have any other fix than the above described workaround, but I did log a bug for one of the libraries that I am using: jimp-dev/jimp#1345

@HarlingtonTigers
Copy link
Author

HarlingtonTigers commented Oct 1, 2024

Thanks for investigating, and for reporting.

I did what you suggested on two test albums. One was happy having JPEG set whilst the other was empty unless PNG was set.

The other thing I noticed was that I had to delete the 0KB files for them to appear at all. The other slightly surprising thing was that the other 22 did not get regenerated.
The log shows that 448 album artwork in the database and 448 artworkIDs and 426 artwork files.

I would have thought that it would try to regenerate the other 22. Am I wrong in my thinking?

Dopamine.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants