Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot override dimensions after definition #11

Closed
jsebrech opened this issue Dec 17, 2019 · 1 comment
Closed

cannot override dimensions after definition #11

jsebrech opened this issue Dec 17, 2019 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jsebrech
Copy link
Contributor

In the v1.x of this library it was possible to set different dimensions at render time, by passing it as a prop to render:
renderUrl("https://widgets...", { dimensions: { width: '100%', height: '500px' } }, myElement);

In v2.x this breaks because of the upgrade to zoid 9 which expects dimensions to be set at define time and cannot override them. The reactComponent function throws an error when trying to pass in dimensions, and the render and renderUrl functions simply ignore dimensions in the props.

This issue has been reported to zoid: krakenjs/zoid#271

@jsebrech jsebrech added the bug Something isn't working label Dec 17, 2019
@jsebrech
Copy link
Contributor Author

jsebrech commented Dec 17, 2019

The current workaround is to set dimensions at define time in overrides to 100% height ({ dimensions: { width: '100%', height: '100%' } }; this can be passed as the 4th parameter to renderUrl) and wrap the widget in a container with fixed height where different heights are needed.

@vademo vademo pinned this issue Dec 17, 2019
jsebrech added a commit that referenced this issue Dec 17, 2019
@jsebrech jsebrech added the wontfix This will not be worked on label May 5, 2023
@jsebrech jsebrech closed this as not planned Won't fix, can't repro, duplicate, stale May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant