Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add path substitution" dialog should not create a new row if "from" and "to" is exactly same #461

Open
sparkhi opened this issue Nov 16, 2023 · 0 comments

Comments

@sparkhi
Copy link
Contributor

sparkhi commented Nov 16, 2023

There is a way to add path substitution using a small dialog. The dialog only has OK button. If someone opens the dialog and presses the "OK" button without entering any values. A new blank line is added to the Path Substitutions table. This is unnecessary. If both values are blank, pressing "OK" should just be treated as pressing "Cancel"

By extension, if both values "from" and "to" are exactly same, the substitution is meaningless, in such case as well, pressing "OK" can be treated as cancel. However, in this case if the user does not realise that this happened because the paths are same, they might be baffled as to why new row is not added, so this extension case needs to be carefully considered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant