Minor Cleanup

Author: digitalcoyote

Src/NuGetDefense.Lib/Scanner.cs

@@ -277,11 +277,11 @@ private void ScanVulnerabilities(ScanOptions options)
                                 vulnDict);
             }
 
-            if (_settings.ErrorSettings.IgnoredCvEs != null)
+            if (_settings.ErrorSettings.IgnoredCvEs is { Length: > 0 })
             {
-                Log.Logger.Information("ignoring {ignoredCVECount} Vulnerabilities", _settings.ErrorSettings.IgnoredCvEs.Length);
-                if (_settings.ErrorSettings.IgnoredCvEs.Length > 0)
-                    VulnerabilityData.IgnoreCVEs(vulnDict, _settings.ErrorSettings.IgnoredCvEs);
+                Log.Logger.Information("ignoring {ignoredCVECount} Vulnerabilities",
+                    _settings.ErrorSettings.IgnoredCvEs.Length);
+                VulnerabilityData.IgnoreCVEs(vulnDict, _settings.ErrorSettings.IgnoredCvEs);
             }
 
             if (vulnDict != null) ReportVulnerabilities(vulnDict);

Src/NuGetDefenseTests/SqliteCacheTests.cs

@@ -32,7 +32,7 @@ public void UpdateCacheNoVulns()
         const string packageVersion = "1.2.3-123Test";
         var pkgs = new[]
         {
-            new NuGetPackage { Version = packageVersion, Dependencies = Array.Empty<string>(), Id = packageId }
+            new NuGetPackage { Version = packageVersion, Dependencies = [], Id = packageId }
         };
 
         cache.UpdateCache(new(), pkgs, TestSourceID);
@@ -52,8 +52,8 @@ public void UpdateCacheWithVulnsCached()
         const string packageVersion = "1.2.3-123Test";
         var pkgs = new[]
         {
-            new NuGetPackage { Version = "4.5.2", Dependencies = Array.Empty<string>(), Id = "no_vulns" },
-            new NuGetPackage { Version = packageVersion, Dependencies = Array.Empty<string>(), Id = packageId }
+            new NuGetPackage { Version = "4.5.2", Dependencies = [], Id = "no_vulns" },
+            new NuGetPackage { Version = packageVersion, Dependencies = [], Id = packageId }
         };
 
         Dictionary<string, Dictionary<string, Vulnerability>> vulns = new()
@@ -96,8 +96,8 @@ public void VulnerabilityUpsertSucceedsWhenVulnerabilityExists()
         const string packageVersion = "1.2.3-123Test";
         var pkgs = new[]
         {
-            new NuGetPackage { Version = "4.5.2", Dependencies = Array.Empty<string>(), Id = "no_vulns" },
-            new NuGetPackage { Version = packageVersion, Dependencies = Array.Empty<string>(), Id = packageId }
+            new NuGetPackage { Version = "4.5.2", Dependencies = [], Id = "no_vulns" },
+            new NuGetPackage { Version = packageVersion, Dependencies = [], Id = packageId }
         };
 
         Dictionary<string, Dictionary<string, Vulnerability>> vulns = new()
@@ -133,8 +133,8 @@ public void VulnerabilityUpsertSucceedsWhenVulnerabilityDoesNotExsist()
         const string packageVersion = "1.2.3-123Test";
         var pkgs = new[]
         {
-            new NuGetPackage { Version = "4.5.2", Dependencies = Array.Empty<string>(), Id = "no_vulns" },
-            new NuGetPackage { Version = packageVersion, Dependencies = Array.Empty<string>(), Id = packageId }
+            new NuGetPackage { Version = "4.5.2", Dependencies = [], Id = "no_vulns" },
+            new NuGetPackage { Version = packageVersion, Dependencies = [], Id = packageId }
         };
 
         Dictionary<string, Dictionary<string, Vulnerability>> vulns = new()

Src/NuGetDefenseTests/VulnerabilityReportsTest.cs

@@ -63,10 +63,10 @@ public void IgnoreVulnerabilitiesForPackage()
         };
 
         IgnorePackages(in pkgs, ignorePkgs, out pkgs);
-        Assert.True(pkgs.Length == 1);
-        Assert.True(pkgs[0].Id == "TestPkg");
-        Assert.True(pkgs[0].Version == "1.0.1");
-        Assert.True(pkgs[0].LineNumber == 1);
+        Assert.Single(pkgs);
+        Assert.Equal("TestPkg", pkgs[0].Id);
+        Assert.Equal("1.0.1", pkgs[0].Version);
+        Assert.Equal(1, pkgs[0].LineNumber);
     }
 
     [Fact]