Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write annotations feature requests #293

Closed
dale-wahl opened this issue Sep 29, 2022 · 2 comments
Closed

Write annotations feature requests #293

dale-wahl opened this issue Sep 29, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request explorer (mostly) back-end Primarily involves the back-end (e.g. post-processors, scheduler or crawlers).

Comments

@dale-wahl
Copy link
Member

I noticed some things that could be improved with the write annotations processor that could be improved when fixing it to work with ndjson files.

  1. New filtered dataset: Explorer view does not include parent annotations
    • If you run write_annotations and create a new filtered dataset, it does not inherit the actual annotations. The annotations are added to the dataset as new fields, but not displayed in Explorer with some dataset types (those that do not include all fields in the style sheets).
  2. New filtered dataset: Preview and CSV download does not include new annotation fields for ndjson filetypes
    • the fields are added to the ndjson file itself, but due to map_item not including the annotation field names are not shown in preview or in the normal CSV download (the NDJSON to CSV processor works still)
  3. Explorer allows annotation field names that could already be field names
    • As a separate database table, this is likely not an issue, but when running write annotations, it can and will overwrite data.
    • This is compounded with ndjson, since a user is not likely to be fully aware of all fieldnames (only the map_item fieldnames).
@dale-wahl dale-wahl added enhancement New feature or request (mostly) back-end Primarily involves the back-end (e.g. post-processors, scheduler or crawlers). labels Sep 29, 2022
@sal-uva
Copy link
Collaborator

sal-uva commented Sep 29, 2022

All great points 👍 Will try to get to this soon(ish).

@sal-uva
Copy link
Collaborator

sal-uva commented Jul 6, 2023

Point 1 is now "fixed" since parent datasets are updated, instead of creating a new one.
Point 2 and 3 are fixed as of e839a4cf

There's some leftover issues:

  • Removed annotation fields are still included in the root dataset instead of removed (maybe this is okay?)
  • Annotation fields are not included in processors. This would involve more advanced edits to map_item, some of which is already facilitated by this pull request: Map item catch #365

@sal-uva sal-uva closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request explorer (mostly) back-end Primarily involves the back-end (e.g. post-processors, scheduler or crawlers).
Projects
None yet
Development

No branches or pull requests

2 participants