You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tl;dr: The SurgeUpgrade field in KubernetesClusterUpdateRequest should not have omitempty in the struct tags. This is preventing users from turning off surge_upgrade after the K8S cluster has been created.
Reproduction steps:
Create K8S cluster in DO. Make sure the surge_upgrade field is set to true
Using godo, update the cluster to disable surge_upgrade
Expected result: surge_upgrade should be turned off
Actual result: surge_upgrade is still on
It may be worthwhile looking for other non-pointer booleans with omitempty on them as well to check if they have the same issue.
The text was updated successfully, but these errors were encountered:
Closing this PR out: at this point, enabling surge upgrades should come with no disadvantages anymore, neither financially nor functionally. We'll officially deprecate the flag going forward.
tl;dr: The
SurgeUpgrade
field inKubernetesClusterUpdateRequest
should not haveomitempty
in the struct tags. This is preventing users from turning offsurge_upgrade
after the K8S cluster has been created.Reproduction steps:
surge_upgrade
field is set to truesurge_upgrade
Expected result:
surge_upgrade
should be turned offActual result:
surge_upgrade
is still onIt may be worthwhile looking for other non-pointer booleans with
omitempty
on them as well to check if they have the same issue.The text was updated successfully, but these errors were encountered: