Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes surge_upgrade field cannot be set to false #524

Open
pcman312 opened this issue Mar 31, 2022 · 3 comments
Open

Kubernetes surge_upgrade field cannot be set to false #524

pcman312 opened this issue Mar 31, 2022 · 3 comments
Assignees

Comments

@pcman312
Copy link

pcman312 commented Mar 31, 2022

tl;dr: The SurgeUpgrade field in KubernetesClusterUpdateRequest should not have omitempty in the struct tags. This is preventing users from turning off surge_upgrade after the K8S cluster has been created.

Reproduction steps:

  1. Create K8S cluster in DO. Make sure the surge_upgrade field is set to true
  2. Using godo, update the cluster to disable surge_upgrade

Expected result:
surge_upgrade should be turned off

Actual result:
surge_upgrade is still on

It may be worthwhile looking for other non-pointer booleans with omitempty on them as well to check if they have the same issue.

@ChiefMateStarbuck
Copy link
Contributor

hello @pcman312 . thank you for the bug report. I've passed this on to the relative team and will have an answer for you shortly.

@timoreimann
Copy link
Contributor

Closing this PR out: at this point, enabling surge upgrades should come with no disadvantages anymore, neither financially nor functionally. We'll officially deprecate the flag going forward.

@timoreimann
Copy link
Contributor

Actually, reopening to track the deprecation still.

@timoreimann timoreimann reopened this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants