Skip to content

Commit

Permalink
Extract e2e job into separate workflow
Browse files Browse the repository at this point in the history
RISDEV-0000
With the separation, the concurrency group is only applied on workflow level and not for each of the matrix e2e jobs individually.
  • Loading branch information
kiwikern committed Sep 27, 2024
1 parent 8b17189 commit 8e61e1e
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 14 deletions.
17 changes: 17 additions & 0 deletions .github/workflows/e2e_matrix.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
jobs:
e2e-matrix:
strategy:
fail-fast: false
matrix:
subproject: [ caselaw, shared ]
browser: [ chromium, firefox ]
mode: [ e2e ]
include:
- mode: a11y
browser: a11y
uses: ./.github/workflows/_playwright-test.yml
with:
subproject: ${{ matrix.subproject}}
browser: ${{ matrix.browser }}
mode: ${{ matrix.mode }}
secrets: inherit
16 changes: 2 additions & 14 deletions .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -364,20 +364,8 @@ jobs:
group: deploy-staging
cancel-in-progress: true
needs: [ deploy-staging, prep-playwright-tests ]
strategy:
fail-fast: false
matrix:
subproject: [ caselaw, shared ]
browser: [ chromium, firefox ]
mode: [ e2e ]
include:
- mode: a11y
browser: a11y
uses: ./.github/workflows/_playwright-test.yml
with:
subproject: ${{ matrix.subproject}}
browser: ${{ matrix.browser }}
mode: ${{ matrix.mode }}
# We do not include the matrix directly, so that the concurrency group does not apply to each matrix job individually
uses: ./.github/workflows/e2e_matrix.yml
secrets: inherit

query-performance-tests:
Expand Down

0 comments on commit 8e61e1e

Please sign in to comment.