Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

tag rendering in webvtt #216

Closed
kimpham54 opened this issue Jul 13, 2017 · 1 comment
Closed

tag rendering in webvtt #216

kimpham54 opened this issue Jul 13, 2017 · 1 comment

Comments

@kimpham54
Copy link
Contributor

kimpham54 commented Jul 13, 2017

Came out of the original interest to render tags from WebVTT files. Consider filter_xss() or other approach.

From @ulsdevteam and @bgilling:

In the “uls_install” branch of our code for islandora_solution_pack_oralhistories the transcripts_ui code has been removed as a submodule and treated like a regular drupal module (but kept as a dependency).

The function that I wrote to rewrite the tags as html is here: https://github.com/ulsdevteam/islandora_solution_pack_oralhistories/blob/uls_install/includes/utilities.inc#L297-L321 – and is called during the compose_vtt_transcript_as_transcripts_ui() routine above this (also in includes/utilities.inc).

In order to let the rewritten html through (the tag becomes a

), the filter_xss call is in here: transcript_ui/theme/transcripts_ui.theme.inc - https://github.com/ulsdevteam/transcripts_ui/blob/master/theme/transcripts_ui.theme.inc#L80.

Finally, these class names used in the

elements needed some styles – which I added to the bottom of the transcript_ui/css/transcripts-ui.css, like https://github.com/ulsdevteam/transcripts_ui/blob/master/css/transcripts-ui.css#L389-L395

@kimpham54
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants