Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawerScreen component accessible at every Screen #70

Open
sanjeevyadavIT opened this issue Sep 19, 2019 · 0 comments
Open

DrawerScreen component accessible at every Screen #70

sanjeevyadavIT opened this issue Sep 19, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sanjeevyadavIT
Copy link
Collaborator

Describe the bug
Since react-native-gesture-handler is enabled in the code, dragging left across the screen opens up the Drawer. There are two Drawer used one showing CategoryTree and other showing DrawerScreen for Category component. And as DrawerScreen drawer is the top most Drawer, swiping left across any screen whether Home, Cart, Login etc, it opens up.

Expected behavior

  1. CategoryTree Drawer should be only accessible from HomeScreen, Login or Account (depending upon user is authenticated or not) and Cart. As soon as other screen are added in their respective stacks, swiping left should not open Drawer.

As , SearchScreen is first level of Bottom tab navigator and it also show products which contain filters, CategoryTree Drawer should not open on swiping left

  1. DrawerScreen drawer should only be accessible from Category and SeacrhScreen
  2. From any other screen which are not mentioned here, drawer should remain disabled.

Current Behavior
DrawerScreen can be access from any screen, by swiping left across the screen

Steps to Reproduce

  1. Open the app on Android phone
  2. Start swiping left across the screen

Solution
First solution(Easy method): Disable gesture
Second Solution: Keep only one Drawer Navigator. Remove DrawerScreen as Drawer and make it a screen that render over top of the Category and search screen
Third Solution: Properly handle both Drawer state as mentioned in Expected behavior.

Screenshots
gif

DrawerScreen accessible from HomeScreen
Screenshot_1568895449

Smartphone (please complete the following information):

  • Magento Version: [2.1.0]
  • Device: [Android Emulator Nexus 5X]
  • OS: [PIE]
  • Version [28]

Additional context
I don't know whether gestures are enabled on iOS or not, but they are enabled on Android.

@sanjeevyadavIT sanjeevyadavIT added the bug Something isn't working label Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants