Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryPipeline incremental update from physics_pipeline doesn't update removed colliders #749

Open
Ughuuu opened this issue Oct 11, 2024 · 1 comment

Comments

@Ughuuu
Copy link
Contributor

Ughuuu commented Oct 11, 2024

When calling physics_pipeline.step, it calls automatically QueryPipeline.update_incremental but gives param refit_and_rebalance to false. If someone doesn't call again QueryPipeline.update then the QueryPipeline.qbvh will keep growing forever (because nodes are marked as dirty but aren't actually removed.

@finnbear
Copy link

finnbear commented Oct 21, 2024

This might relate to #617 (although, at the time of writing, I thought refit_and_rebalance was true at least once per step)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants