Skip to content

Commit

Permalink
Ensure third-party-podspecs depend on react_native_pods.rb
Browse files Browse the repository at this point in the history
These podspecs all depend on a function defined in another Ruby file
(which is kind of scary, but prooobably okay). However, they do not
`require` that file, and instead (previously) were just relying on the
fact that CocoaPods loads all the podspecs declared in your Podfile.

This is fine for `pod install`, but doesn't apply to commands like `pod
ipc spec` (which is used to convert an individual Podspec file to JSON).
With that command, the PodSpecs were not evaluating successfully, as
they didn't have access to this function.

So we add the proper requires here and call it a day.
  • Loading branch information
stevenpetryk committed Aug 14, 2024
1 parent 9e36ff4 commit a01218b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

require_relative "../scripts/react_native_pods"

Pod::Spec.new do |spec|
spec.name = 'DoubleConversion'
spec.version = '1.1.6'
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/third-party-podspecs/RCT-Folly.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

require_relative "../scripts/react_native_pods"

folly_config = get_folly_config()
folly_compiler_flags = folly_config[:compiler_flags]
folly_release_version = folly_config[:version]
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/third-party-podspecs/boost.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

require_relative "../scripts/react_native_pods"

Pod::Spec.new do |spec|
spec.name = 'boost'
spec.version = '1.83.0'
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/third-party-podspecs/fmt.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

require_relative "../scripts/react_native_pods"

Pod::Spec.new do |spec|
spec.name = "fmt"
spec.version = "9.1.0"
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/third-party-podspecs/glog.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

require_relative "../scripts/react_native_pods"

Pod::Spec.new do |spec|
spec.name = 'glog'
spec.version = '0.3.5'
Expand Down

0 comments on commit a01218b

Please sign in to comment.