Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update deprecated emoji test #10607

Merged
merged 2 commits into from
Nov 27, 2024
Merged

test: Update deprecated emoji test #10607

merged 2 commits into from
Nov 27, 2024

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Passing a string emits a deprecation warning. Amended it to the non-deprecated variant.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 8:27am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2024 8:27am

@Jiralite Jiralite added the tests label Nov 19, 2024
@Jiralite Jiralite added this to the rest 3.0.0 milestone Nov 19, 2024
@Jiralite Jiralite modified the milestones: rest 3.0.0, rest 2.5.0 Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.97%. Comparing base (0374079) to head (bd80d70).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10607      +/-   ##
==========================================
- Coverage   38.18%   37.97%   -0.22%     
==========================================
  Files         239      239              
  Lines       15563    15528      -35     
  Branches     1376     1374       -2     
==========================================
- Hits         5943     5896      -47     
- Misses       9605     9617      +12     
  Partials       15       15              
Flag Coverage Δ
rest 85.85% <ø> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 97ffa20 into main Nov 27, 2024
14 checks passed
@kodiakhq kodiakhq bot deleted the test/rest-not-deprecated branch November 27, 2024 08:31
@Jiralite Jiralite modified the milestones: rest 2.5.0, rest 3.0.0 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants