Fix struct view annotation styling to avoid treating href values …

…as links when they are falsy
discoveryjs · Mar 19, 2024 · 834f119 · 834f119
1 parent d05ec46
commit 834f119
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@
 - Enabled `positionMode: natural` for tooltips by default, can be changed via tooltip options
 - Exposed type checking helpers `isArray()`, `isSet()` and `isRegExp()`
 - Fixed `badge` view options when it receives an array as data
+- Fixed `struct` view annotation styling to avoid treating `href` values as links when they are falsy
 - Fixed a sticky tooltip for "Enable view inspection" button on inspecting start
 - Fixed the delayed popup display after calling the `hide()` method
 - Fixed positioning of popups with `position: pointer`

diff --git a/src/views/struct/render-annotations.js b/src/views/struct/render-annotations.js
@@ -34,7 +34,7 @@ export default function renderAnnotations(annotations) {
 
         const annotationEl = createElement(href ? 'a' : 'span', {
             class: elClassName,
-            href,
+            href: typeof href === 'string' ? href : undefined,
             target: external ? '_blank' : undefined
         });