Add support for TypedArrays for group() method

discoveryjs · May 18, 2024 · 3fd533c · 3fd533c
1 parent 80ddb57
commit 3fd533c
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/src/methods.js b/src/methods.js
@@ -153,14 +153,14 @@ export default Object.freeze({
             valueGetter = self;
         }
 
-        if (!Array.isArray(current)) {
+        if (!isArray(current)) {
             current = [current];
         }
 
         for (const item of current) {
             const keys = keyGetter(item);
 
-            if (Array.isArray(keys)) {
+            if (isArray(keys)) {
                 if (keys.length > 0) {
                     const value = valueGetter(item);
 

diff --git a/test/methods/group.js b/test/methods/group.js
@@ -77,4 +77,36 @@ describe('group()', () => {
             ]
         );
     });
+
+    describe('should work with TypedArrays', () => {
+        it('group TypedArray elements', () => {
+            assert.deepEqual(
+                query('group(=>$ % 2 ? "odd" : "even")')(new Uint8Array([1, 2, 3, 4, 5])),
+                [
+                    { key: 'odd', value: [1, 3, 5] },
+                    { key: 'even', value: [2, 4] }
+                ]
+            );
+        });
+
+        it('group by TypedArray', () => {
+            const data = [
+                { id: 1, tags: new Uint8Array([1, 2]) },
+                { id: 2, tags: new Uint8Array([2, 3]) },
+                { id: 3, tags: new Uint8Array([3, 4]) },
+                { id: 4, tags: new Uint8Array([]) }
+            ];
+
+            assert.deepEqual(
+                query('group(=>tags)')(data),
+                [
+                    { key: 1, value: [data[0]] },
+                    { key: 2, value: [data[0], data[1]] },
+                    { key: 3, value: [data[1], data[2]] },
+                    { key: 4, value: [data[2]] },
+                    { key: undefined, value: [data[3]] }
+                ]
+            );
+        });
+    });
 });