Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should do something useful with git submodules #63

Open
disruptek opened this issue Dec 13, 2019 · 1 comment · May be fixed by #140
Open

should do something useful with git submodules #63

disruptek opened this issue Dec 13, 2019 · 1 comment · May be fixed by #140
Labels
enhancement New feature or request

Comments

@disruptek
Copy link
Owner

No description provided.

@disruptek disruptek added the enhancement New feature or request label Dec 13, 2019
@disruptek disruptek added this to the remove Nimble dependency milestone Aug 19, 2020
@disruptek
Copy link
Owner Author

So the tricky bit here is figuring out how and where to specify requirements as we move them into git submodules. The larger goal here, and the reason I moved this into the milestone, would be to eliminate the .nimble files altogether.

The most obvious solution I could come up with would be to overload the name field in the .gitmodules to include the acceptable versions. Maybe we can add some other arbitrary key/value pairs in there, too; I rarely use submodules and I don't really know how much we can hack at this.

Here's an example for reference:

[submodule "bump ~1.8.* & < 2"]
  path = bump
  url = https://github.com/disruptek/bump
[submodule "github ^2.0.3 & < 3.0"]
  path = github
  url = https://github.com/disruptek/github

cc @Clyybber

@disruptek disruptek linked a pull request Aug 23, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant