This repository was archived by the owner on Jul 17, 2022. It is now read-only.
Added checkbox for terms and conditions #802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderbyheart
suggested changes
May 29, 2022
Comment on lines
+4
to
+7
| await queryInterface.addColumn(`Groups`, 'termsAndConditionsAcceptedAt', { | ||
| allowNull: false, | ||
| type: DataTypes.DATE, | ||
| }) |
There was a problem hiding this comment.
problem: this needs to be a User property, not a Group property.
There was a problem hiding this comment.
Hmm, what if one user creates multiple groups?
There was a problem hiding this comment.
That's fine. In that case they have already accepted the Terms & Conditions. They apply to humans, not to groups. Groups are legally represented by humans, so the humans have to accept the terms.
There was a problem hiding this comment.
Thanks for explanation! I'll work on change and create new PR
| className="cursor-pointer text-blue-500" | ||
| onClick={() => setShowTermsAndCond(true)} | ||
| > | ||
| I accept terms and conditions |
There was a problem hiding this comment.
nitpick: use CSS to add spacing, not content.
coderbyheart
changed the title
4 tasks
|
Closing in favour of #844 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checkbox for terms and conditions
Prompting window with terms and conditions text
Sending time when it's checked to backend and storing it in postgres
(WIP) Missing terms and conditions text!
See #714