Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalizing the DJI Key from the code. #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,9 @@ Note that if you are using QGroundControl on the same device as RosettaDrone, th

3. Sign up for the DJI Developer Program at https://developer.dji.com/mobile-sdk/ and create an Application key. The package name should be sq.rogue.rosettadrone.

4. Create a new file called keys.xml in the /values folder, and insert the following:
4. Create a new file `~/.gradle/gradle.properties` if you don't have one yet, and add the following line to it:
```
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="dji_key">INSERT KEY HERE</string>
</resources>
DJI_API_KEY_ROSETTA_DRONE=INSERT KEY HERE
```

5. Run **Build->Make Project**
Expand Down
1 change: 1 addition & 0 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ android {
versionName "1.2.1"
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
multiDexEnabled true
manifestPlaceholders = [DJIApiKey: project.properties['DJI_API_KEY_ROSETTA_DRONE']]
}

buildTypes {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<uses-library android:name="com.android.future.usb.accessory"/>
<meta-data
android:name="com.dji.sdk.API_KEY"
android:value="@string/dji_key"/>
android:value="${DJIApiKey}"/>

<service android:name="dji.sdk.sdkmanager.DJIGlobalService">
</service>
Expand Down