Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for plugin Flash #655

Closed
jrief opened this issue Oct 13, 2023 · 3 comments
Closed

Deprecation warning for plugin Flash #655

jrief opened this issue Oct 13, 2023 · 3 comments

Comments

@jrief
Copy link
Collaborator

jrief commented Oct 13, 2023

Whenever I open a text-ckeditor plugin, I get this deprecation warning:

Screenshot 2023-10-13 at 08 54 38

I know, @fsbraun disabled "flash" in 31cb918 , so it seems strange that it still is in use. It seems that it has to be removed from here, which is a file beyond our control.

@fsbraun
Copy link
Member

fsbraun commented Oct 16, 2023

I agree. It's an artefact from using Ckeditor 4. It could (only) be removed by patching Ckeditor 4.

@MacLake
Copy link
Contributor

MacLake commented Oct 20, 2023

No, you can also remove the Flash plug-in in the config. While defining the set of buttons doesn’t seem to help, using 'removePlugins' does the trick. I just learnt that from Vinit’s answer in the Slack support channel when I asked how to get rid of Word formatting. So here are my settings:

CKEDITOR_SETTINGS: dict[str, Union[str, list]] = {
    'removePlugins':
        ['pastefromword', 'flash'],
    'pasteFilter':
        "p b i u h1 h2 h3 h4 h5 h6 ul ol li; table tr td sub sup; a[href]",
    'stylesSet': 'default:/static/js/addons/ckeditor.wysiwyg.js',
    'contentsCss': ['/static/semantic/semantic.min.css'],
}

@MacLake
Copy link
Contributor

MacLake commented Oct 20, 2023

I’ve added it to the default config:
#656

@fsbraun fsbraun closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants