Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: CMS 4.1 compatible #89

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

joshyu
Copy link
Contributor

@joshyu joshyu commented Nov 5, 2024

No description provided.

@joshyu joshyu marked this pull request as draft November 5, 2024 01:15
@joshyu joshyu marked this pull request as ready for review November 5, 2024 01:35
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.03%. Comparing base (075d745) to head (1428d8e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   77.76%   78.03%   +0.26%     
==========================================
  Files          30       30              
  Lines         778      783       +5     
  Branches       76       66      -10     
==========================================
+ Hits          605      611       +6     
  Misses        153      153              
+ Partials       20       19       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun
Copy link
Member

fsbraun commented Nov 5, 2024

@joshyu Great work! Look like it's working!

I am also concerned with Django 5 compatibility. Did you take a look while at it?

@joshyu
Copy link
Contributor Author

joshyu commented Nov 5, 2024

@joshyu Great work! Look like it's working!

I am also concerned with Django 5 compatibility. Did you take a look while at it?

@fsbraun , sorry I have too much work for now. but I will check it later.

@fsbraun fsbraun merged commit 4851ffb into django-cms:master Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants