Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't really understand your instructions #69

Open
stanleykywong opened this issue Jul 24, 2022 · 5 comments
Open

Don't really understand your instructions #69

stanleykywong opened this issue Jul 24, 2022 · 5 comments

Comments

@stanleykywong
Copy link

stanleykywong commented Jul 24, 2022

After installing djangocms-video with pip, and trying to add the codes, however, I don't know which files I should modify, as I can't see from your instructions. e.g. you may simply say:

you can provide additional template choices by adding a DJANGOCMS_VIDEO_TEMPLATES setting:

DJANGOCMS_VIDEO_TEMPLATES = [
('feature', _('Featured Version')),
]

but I don't know which file I should modify.

Can you please provide the file names and the relevant paths? Thanks.

@marksweb
Copy link
Member

@stanleykywong Those are settings to add to your settings.py file in your project.

You can find the full docs for django settings here; https://docs.djangoproject.com/en/4.0/topics/settings/

@Noah3141
Copy link

Noah3141 commented Feb 1, 2024

Am I intended to edit the code in the package itself, rather than have a within-project templates/djangocms_video/{template_name}/video_player.html?
I am trying to make a custom template because for some reason the video is being embedded in its own entire HTML document markup, rather than a minimal tag.

@fsbraun
Copy link
Member

fsbraun commented Feb 1, 2024

The standard approach is having an app provide the templates for your custom player markup. Modifying the package will get overwritten when updating or reinstalling the package.

@Noah3141
Copy link

Noah3141 commented Feb 1, 2024

I see now, the traceback provides where it is looking. It wants the templates dir inside the core app not the root of the project.

@Noah3141
Copy link

Noah3141 commented Feb 1, 2024

Upon making my own minimal template... Even mine is being splayed out into an entire HTML document for some reason. This is uh... Something else's fault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants