Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required setting, FLUENT_PAGES_TEMPLATE_DIR, not mentioned in README.rst #32

Open
mrmachine opened this issue Apr 5, 2014 · 0 comments

Comments

@mrmachine
Copy link
Contributor

The FLUENT_PAGES_TEMPLATE_DIR is a required setting. Even though it defaults to TEMPLATE_DIRS[0], Django's default settings.py doesn't provide a TEMPLATE_DIR setting.

It also seems a bit arbitrary to nominate the first TEMPLATE_DIRS directory as the only location where fluent-pages templates can be found. Who knows what people have in TEMPLATE_DIRS or what order it is. The order doesn't matter for Django, so fluent-pages shouldn't rely on it.

How about providing a custom template loader, based on Django's app_directories loader, that looks in the fluent_page_templates directory for all installed apps, and use the FLUENT_PAGES_TEMPLATE_DIR (or DIRS) setting to add project level directories that are searched before the app directories?

And also mention in the instructions that the custom app loader should be installed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant