Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slashes in URI/path #275

Open
gena01 opened this issue Aug 1, 2019 · 5 comments · May be fixed by #443
Open

Trailing slashes in URI/path #275

gena01 opened this issue Aug 1, 2019 · 5 comments · May be fixed by #443
Labels
stale

Comments

@gena01
Copy link

gena01 commented Aug 1, 2019

I was going through https://lucene.apache.org/solr/guide/8_1/solr-tutorial.html and was trying to get pysolr working on my end.

I noticed that the URI's no longer have trailing slashes and there's no way to turn that off?

pysolr/pysolr.py

Line 475 in a2f2526

path = "%s/?%s" % (handler, params_encoded)

pysolr/pysolr.py

Line 479 in a2f2526

path = "%s/" % handler

pysolr/pysolr.py

Line 525 in a2f2526

path = "%s/" % path_handler

@acdha
Copy link
Collaborator

acdha commented Aug 1, 2019

Is this causing a problem and if so with what version of Solr - 8.1? I’ve mostly used it with 7 and earlier so we might need to update for this.

@gena01
Copy link
Author

gena01 commented Aug 8, 2019

So I know that it's causing us an issue with our solr 7.5 configuration.

I tried to research this through the solr guides/docs.. went as far back as solr 4.4 guide pdf. The section that looks interesting is the "Client API" that has a Python example that looks something like:

connection = urlopen('http://localhost:8983/solr/select?q=cheese&wt=python')
response = eval(connection.read())

@stale
Copy link

stale bot commented Nov 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 6, 2019
@gena01
Copy link
Author

gena01 commented Nov 7, 2019

Any update on this? would you consider a PR?

@acdha
Copy link
Collaborator

acdha commented Nov 7, 2019

Please send a PR — I have very little time available for open source these days and this isn't something I need for my projects.

@SupraSummus SupraSummus linked a pull request Nov 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove trainling slashes from URLs EE/pysolr3
2 participants
@acdha @gena01