Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated API endpoint #8

Open
1john opened this issue May 8, 2019 · 3 comments
Open

Outdated API endpoint #8

1john opened this issue May 8, 2019 · 3 comments

Comments

@1john
Copy link

1john commented May 8, 2019

The endpoint in gateway.py is outdated.

The template on line 18 should be changed to:

URL_TEMPLATES = {
    'post_tax': purl.Template('/api{/version}/transactions/create'),
}

and the version in line 30 should be changed to:

url_params['version'] = 'v2'

as the avalara tax api has changed quite a bit between versions, many more code changes will be needed. One large issue is that all of the variables in the payload in facade.py need to be changed to have lowercase first letters or changed entirely.

@sasha0
Copy link
Member

sasha0 commented May 9, 2019

Ok, thanks for the feedback.

I'll try to get test account and proceed with the further changes on.

@1john
Copy link
Author

1john commented May 9, 2019

🙏

@1john
Copy link
Author

1john commented May 9, 2019

I created this repository so you could see how I did it and reference some of the variables names and things.

https://github.com/1john/django_avalara_integration

Might help speed things up a bit for you.

Keep an eye out though, I am using django-oscar-api for a custom front end, so some of the things won't make sense for you. Things like line 131 of facade.py where I cast shipping_address to a frozen set before hashing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants