Update docker-compose.yml to use hyphen in all resources names instead of underscore
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of underscore - Update `name` by replacing `_` with `-` so that the prefix for resources names uses a hyphen; - Update volumes names to use hyphen.
SergeyKubrak
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if
project_slugcontaint underscores, then names of docker resources is not consistend because containter names use hyphen as separator (e.g. ds_skeleton_sandbox-celery-beat), so I decied to improve that.Change list
nameby replacing_with-so that the prefix for resources names uses a hyphen;Unfortunately due to backward incompatibility reasons in compose-spec/compose-go#294 networks and volumes still will have underscore between "name" prefix and resource name itself (e.g. ds-skeleton-sandbox_pg-data). But I think names are more consistent this way anyway.