Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immediate native crash when loading first patch on Pixel 7 Pro #48

Open
philburk opened this issue Mar 6, 2024 · 4 comments
Open

immediate native crash when loading first patch on Pixel 7 Pro #48

philburk opened this issue Mar 6, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@philburk
Copy link

philburk commented Mar 6, 2024

Device Pixel 7 Pro
OS UDC beta AP1A.240305.019

REPRO STEPS
Install from Play Store
Connect analog iRig 2 to a Google USB headset adapter.
Connect USB adapter to phone.
Launch app.
Go through Wizard.
Press Tap to Load

EXPECT - see patch load and begin running

ACTUAL - app crashed immediately

Native crash stackdump from the bugreport:
amprack_stackdump.txt

Let me know if you need more info.

@djshaji
Copy link
Owner

djshaji commented Mar 6, 2024

Hi,
It seems that a plugin is causing the app to crash before it can load. As a temporary fix, you can delete the app's data to reset it.

I will add this issue to the next version's todo list, as there ought to be a mechanism to blacklist plugins which don't load properly on some devices.

@djshaji djshaji added the bug Something isn't working label Mar 6, 2024
@djshaji djshaji added this to the Nighthawk milestone Mar 6, 2024
@djshaji djshaji self-assigned this Mar 6, 2024
@djshaji
Copy link
Owner

djshaji commented Mar 27, 2024

Hi, was the problem resolved?

@djshaji djshaji removed this from the Nighthawk milestone Mar 27, 2024
@philburk
Copy link
Author

philburk commented Apr 1, 2024

No. I uninstalled the app and reinstalled it. Version 4.02.
It crashes immediately.

Did you look at the stack trace? It mentions several Echo and Delay plugins.

Abort message: 'engine is NULL'
(delayline::delay_simple(float, float, int, int, int)+1356)
(Echo::out(float*, float*, unsigned int)+200)
(run_echolv2(void*, unsigned int)+784)

there ought to be a mechanism to blacklist plugins which don't load properly on some devices.

A better solution would be to track down the NULL pointer exception and fix it.
There may be a race condition in your initialization.

@djshaji
Copy link
Owner

djshaji commented Apr 3, 2024

Knock knock
Race Condition!
Whose there?

You were right. There was indeed a race condition between the UI thread and the Audio thread. Fixed in 17df08a

I've published an update (version 4.03). Do check it out and see if the problem is fixed, so I can close the issue.

Thanks.

@djshaji djshaji modified the milestones: Raptor, Razor Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants