Fix #18281 - ICE on attempt to compare deref of two functions ptr (#2…

…0768)
dlang · Jan 23, 2025 · 72a9347 · 72a9347
1 parent ac9e8a5
commit 72a9347
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/compiler/src/dmd/expressionsem.d b/compiler/src/dmd/expressionsem.d
@@ -13496,6 +13496,11 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
             error(exp.loc, "compare not defined for complex operands");
             return setError();
         }
+        else if (t1.isTypeFunction() || t2.isTypeFunction())
+        {
+            error(exp.loc, "comparison is not defined for function types");
+            return setError();
+        }
         else if (t1.ty == Taarray || t2.ty == Taarray)
         {
             error(exp.loc, "`%s` is not defined for associative arrays", EXPtoString(exp.op).ptr);
@@ -13816,6 +13821,12 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
             return;
         }
 
+        if (t1.isTypeFunction() || t2.isTypeFunction())
+        {
+            error(exp.loc, "operator `==` is not defined for function types");
+            return setError();
+        }
+
         if (auto tv = t1.isTypeVector())
             exp.type = tv.toBooleanVector();
 
@@ -13877,6 +13888,12 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
         if (exp.e2.op == EXP.call)
             exp.e2 = (cast(CallExp)exp.e2).addDtorHook(sc);
 
+        if (exp.e1.type.isTypeFunction() || exp.e2.type.isTypeFunction())
+        {
+            error(exp.loc, "operator `is` is not defined for function types");
+            return setError();
+        }
+
         if (exp.e1.type.toBasetype().ty == Tsarray ||
             exp.e2.type.toBasetype().ty == Tsarray)
             deprecation(exp.loc, "identity comparison of static arrays "

diff --git a/compiler/test/fail_compilation/fail22151.d b/compiler/test/fail_compilation/fail22151.d
@@ -2,10 +2,13 @@
 /*
 TEST_OUTPUT:
 ---
-fail_compilation/fail22151.d(14): Error: function `test` is not an lvalue and cannot be modified
-fail_compilation/fail22151.d(15): Error: function `test2` is not an lvalue and cannot be modified
-fail_compilation/fail22151.d(18): Error: function pointed to by `fp` is not an lvalue and cannot be modified
-fail_compilation/fail22151.d(21): Error: function pointed to by `ff` is not an lvalue and cannot be modified
+fail_compilation/fail22151.d(17): Error: function `test` is not an lvalue and cannot be modified
+fail_compilation/fail22151.d(18): Error: function `test2` is not an lvalue and cannot be modified
+fail_compilation/fail22151.d(21): Error: function pointed to by `fp` is not an lvalue and cannot be modified
+fail_compilation/fail22151.d(24): Error: function pointed to by `ff` is not an lvalue and cannot be modified
+fail_compilation/fail22151.d(27): Error: operator `==` is not defined for function types
+fail_compilation/fail22151.d(28): Error: operator `is` is not defined for function types
+fail_compilation/fail22151.d(29): Error: comparison is not defined for function types
 ---
 */
 
@@ -19,6 +22,11 @@ void test()
 
     auto ff = &test2;
     *ff = *&test2;
+
+    // https://github.com/dlang/dmd/issues/18281
+    const c = *fp == *fp;
+    const d = *fp is *fp;
+    const e = *fp < *fp;
 }
 
 void test2();