Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize normalizer behavior with regards to file_max_items and file_max_size #2029

Open
sh-rp opened this issue Nov 6, 2024 · 0 comments

Comments

@sh-rp
Copy link
Collaborator

sh-rp commented Nov 6, 2024

The normalizers behave differently for example if

  dlt.config["data_writer.file_max_items"] = 100
  dlt.config["data_writer.file_max_bytes"] = 100

are set. This needs to be investigated further. For example if the loader file format is parquet and the user is yielding arrow tables from the resource, the file_max_bytes seems to be ignore and file_max_items only is respected if the the rowcount of the yielded arrow table is smaller than this. We can either fix this, or if this behavior is intentional for performance reasons print a warning or info to the logger so it is less confusing for the user.

@sh-rp sh-rp moved this to Planned in dlt core library Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

1 participant