Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salesforce column names not following naming convention correctly #2087

Open
lsimon14 opened this issue Nov 22, 2024 · 1 comment
Open

Salesforce column names not following naming convention correctly #2087

lsimon14 opened this issue Nov 22, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lsimon14
Copy link

dlt version

1.4

Describe the problem

In version 1.3 and earlier, running a Salesforce pipeline to Postgres converted double underscores to single underscores for table column names, but does not in version 1.4. The Salesforce api naming conventions are to append __c to all custom fields, when I run the pipeline in 1.4 it recreates all of the custom table columns as new columns. So example_custom_field__c was previously loaded in as example_custom_field_c in 1.3, but was recreated as example_custom_field__c in 1.4.

Expected behavior

Salesforce destination column names replace double underscores with single underscores.

Steps to reproduce

Using the Salesforce verified source create a pipeline that pulls data from Salesforce, which includes a field whose API name has two underscores (any custom field will meet this criterion). Run the pipeline with Postgres as the destination and observe that the output column names retain the double underscore.

Operating system

macOS

Runtime environment

Local

Python version

3.10

dlt data source

Salesforce

dlt destination

Postgres

Other deployment details

No response

Additional information

No response

@rudolfix rudolfix self-assigned this Nov 25, 2024
@rudolfix rudolfix added the bug Something isn't working label Nov 25, 2024
@rudolfix
Copy link
Collaborator

@lsimon14 thanks for reporting this. we fixed several normalization issues in the last release. they were affecting arrow tables and column names, any other sources should work as previously. I'll investigate this, looks pretty important...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

2 participants