We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PresentationModel.lifecycleObservable won't emit the Lifecycle.DESTROYED if subscribed with added untilDestroy(). It is because of this part:
PresentationModel.lifecycleObservable
Lifecycle.DESTROYED
untilDestroy()
lifecycleObservable .takeUntil { it == Lifecycle.DESTROYED } .subscribe { when (it) { ... Lifecycle.DESTROYED -> { compositeDestroy.clear() onDestroy() } } ...
lifecycleObservable calls the compositeDestroy.clear() and untilDestroy will unsubscribe the source, so our subscription won't get the DESTROYED.
compositeDestroy.clear()
untilDestroy
Logically it's ok, but it makes lifecycleObservable less usable in practice. Think we need to change this to get DESTROYED before unsubscribing.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
PresentationModel.lifecycleObservable
won't emit theLifecycle.DESTROYED
if subscribed with addeduntilDestroy()
.It is because of this part:
lifecycleObservable calls the
compositeDestroy.clear()
anduntilDestroy
will unsubscribe the source, so our subscription won't get the DESTROYED.Logically it's ok, but it makes lifecycleObservable less usable in practice. Think we need to change this to get DESTROYED before unsubscribing.
The text was updated successfully, but these errors were encountered: