Skip to content

Commit

Permalink
upstream: tweak proctitle to include sshd arguments, as these are
Browse files Browse the repository at this point in the history
frequently used to distinguish between multiple independent instances of the
server. New proctitle looks like this:

$ pgrep -lf sshd
12844 sshd: /usr/sbin/sshd -f /etc/ssh/sshd_config [listener] 0 of 10-100 startups

requested by sthen@ and aja@; ok aja@

OpenBSD-Commit-ID: cf235a561c655a3524a82003cf7244ecb48ccc1e
  • Loading branch information
djmdjm committed Jan 25, 2020
1 parent 8075fcc commit a8c05c6
Showing 1 changed file with 18 additions and 4 deletions.
22 changes: 18 additions & 4 deletions sshd.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* $OpenBSD: sshd.c,v 1.544 2020/01/23 07:10:22 dtucker Exp $ */
/* $OpenBSD: sshd.c,v 1.545 2020/01/24 23:56:01 djm Exp $ */
/*
* Author: Tatu Ylonen <[email protected]>
* Copyright (c) 1995 Tatu Ylonen <[email protected]>, Espoo, Finland
Expand Down Expand Up @@ -262,6 +262,8 @@ void destroy_sensitive_data(void);
void demote_sensitive_data(void);
static void do_ssh2_kex(struct ssh *);

static char *listener_proctitle;

/*
* Close all listening sockets
*/
Expand Down Expand Up @@ -1087,9 +1089,9 @@ server_accept_loop(int *sock_in, int *sock_out, int *newsock, int *config_s)
*/
for (;;) {
if (ostartups != startups) {
setproctitle("[listener] %d of %d-%d startups",
startups, options.max_startups_begin,
options.max_startups);
setproctitle("%s [listener] %d of %d-%d startups",
listener_proctitle, startups,
options.max_startups_begin, options.max_startups);
ostartups = startups;
}
if (received_sighup) {
Expand Down Expand Up @@ -1435,6 +1437,17 @@ accumulate_host_timing_secret(struct sshbuf *server_cfg,
sshbuf_free(buf);
}

static char *
prepare_proctitle(int ac, char **av)
{
char *ret = NULL;
int i;

for (i = 0; i < ac; i++)
xextendf(&ret, " ", "%s", av[i]);
return ret;
}

/*
* Main program for the daemon.
*/
Expand Down Expand Up @@ -1911,6 +1924,7 @@ main(int ac, char **av)
rexec_argv[rexec_argc] = "-R";
rexec_argv[rexec_argc + 1] = NULL;
}
listener_proctitle = prepare_proctitle(ac, av);

/* Ensure that umask disallows at least group and world write */
new_umask = umask(0077) | 0022;
Expand Down

0 comments on commit a8c05c6

Please sign in to comment.