Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace hardcoded hostnames with environment variables #803

Open
vkuznet opened this issue Aug 20, 2019 · 0 comments
Open

replace hardcoded hostnames with environment variables #803

vkuznet opened this issue Aug 20, 2019 · 0 comments

Comments

@vkuznet
Copy link
Contributor

vkuznet commented Aug 20, 2019

We have hardcoded host names, such as cmsweb.cern.ch, cmsweb-testbed.cern.ch in various places. For instance, these names are used in deploy scripts. But for k8s setup deploy scripts are used during build of image, i.e. it implies that these names are propagated into the image. We should remove all hardcoded host names and replace them as following:

cmsweb_prod=${CMSWEB_HOSTNAME:-cmsweb.cern.ch}
cmsweb_preprod=${CMSWEB_HOSTNAME:-cmsweb-testbed.cern.ch}

and then replace usage of host names with $cmsweb_prod and $cmsweb_preprod variables. This will allow to manipulate host names during k8s deployment where we can set appropriate host name via environment variables. Then we can adjust cmsweb docker images to rely on this environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant