Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the minimum number of players for the game session #2

Open
ivellios opened this issue Dec 18, 2020 · 0 comments
Open

Change the minimum number of players for the game session #2

ivellios opened this issue Dec 18, 2020 · 0 comments

Comments

@ivellios
Copy link
Member

ivellios commented Dec 18, 2020

Background

Currently, we have a minimum number of players for the game hardcoded in our backend and frontend to check different logic. The value now is set to 2 players.

Feature improvement

We would like to change this value to be set in the configuration or at least const file, so it can be changed to fit the needs of the community.

Technical details

https://github.com/dnd-al-krk/portal_backend/blob/master/games/models.py#L186 is one of the places where the value is hardcoded. It is also in some places of the frontend code. Should be identified and replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant