[Feat#38] Github Action workflow 분리 및 mysql db production 적용 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlight258
approved these changes
Feb 17, 2024
| @@ -1,7 +1,7 @@ | |||
| version: '3.7' | |||
| services: | |||
| db: | |||
| image: mysql:5.7 | |||
| image: mysql:8-oracle | |||
There was a problem hiding this comment.
arm 아키텍처도 지원되는 이미지로 수정해주셔서 감사해요!!
제 노트북에서도 잘 작동하네요 😄
Comment on lines
+6
to
+10
| environment: | ||
| MYSQL_DATABASE: '{MYSQL_DATABASE}' | ||
| MYSQL_USER: '${MYSQL_USER}' | ||
| MYSQL_PASSWORD: '${MYSQL_PASSWORD}' | ||
| MYSQL_ROOT_PASSWORD: '${MYSQL_ROOT_PASSWORD}' |
There was a problem hiding this comment.
환경변수 사용해서 설정값 분리 잘 하셨습니다!! 💯 보안상 이슈는 없어보여요! 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
resolved: #38 #42
🛠 개발 기능
🧩 해결 방법
🔍 리뷰 포인트
📋 Code Review Priority Guideline