Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/#36] 닉네임 추가 기능을 개발한다. #45

Merged
merged 2 commits into from
Feb 18, 2024
Merged

[Feat/#36] 닉네임 추가 기능을 개발한다. #45

merged 2 commits into from
Feb 18, 2024

Conversation

Starlight258
Copy link
Collaborator

@Starlight258 Starlight258 commented Feb 18, 2024 •
edited
Loading

🔗 Linked Issue

resolved #36

🛠 개발 기능

  • 닉네임 추가 기능 개발
  • PR_TEMPLATE 폴더명을 PULL_REQUEST_TEMPLATE으로 수정하여 깃허브가 인식하도록 변경
  • Spring Security에서 /api/members를 Open url에서 제외

🧩 해결 방법

  • /api/members를 Open url에서 제외하여 @ReqUser 어노테이션이 토큰으로부터 member를 잘 가져오도록 수정했습니다.
    (Open Url로 포함될 경우 인증 과정이 수행되지 않음)

🔍 리뷰 포인트

  • 간단한 기능이라 로직 잘 짜여졌는지 확인만 해주시면 될 듯 합니다 😄
  • PR_TEMPLATE 적용 이슈때문에 merge 후에 바로 dev->main PR도 올리겠습니다 !

@Starlight258 Starlight258 added this to the Sprint 3 milestone Feb 18, 2024
@Starlight258 Starlight258 self-assigned this Feb 18, 2024
@Starlight258 Starlight258 changed the base branch from main to dev February 18, 2024 07:59
FacerAin
FacerAin approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@FacerAin FacerAin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기능 군더더기 없이 깔끔하게 잘 구현하신 것 같아요! 바로 Merge 할게요! 고생 많으셨어요 👍

@FacerAin FacerAin merged commit 976a5cb into dev Feb 18, 2024
1 check passed
@Starlight258 Starlight258 deleted the feat/add-nickname branch February 18, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FacerAin FacerAin FacerAin approved these changes

Assignees

@Starlight258 Starlight258

Labels
🟡 Priority: Medium 🔛 Status: In Progress 🐛 Type: Bug ✨ Type: Enhancement
Projects
None yet
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

feat: 닉네임 추가 기능을 개발한다
2 participants
@Starlight258 @FacerAin