Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat#48] Production을 위한 Oauth2 redirect-uri 로직 수정 #49

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

FacerAin
Copy link
Collaborator

What is this PR? 🔍

  • production을 위한 redirect-uri 검증 로직을 수정하였습니다.

Changes 📝

  • AUTHORIZED_REDIRECT_URIS 환경 변수에 등록된 URI의 redirection을 허용합니다.
  • application-prod,test,local 파일이 수정되었으며, 이는 팀 내부 문서에 공유하겠습니다.

Screenshot 📷

Nan

@FacerAin FacerAin added this to the Sprint 3 milestone Feb 19, 2024
@FacerAin FacerAin self-assigned this Feb 19, 2024
Comment on lines +83 to +90
for (String authorizedRedirectUri : AUTHORIZED_REDIRECT_URIS) {
URI authorizedUri = URI.create(authorizedRedirectUri);
if (authorizedUri.getHost().equalsIgnoreCase(clientRedirectUri.getHost())
&& authorizedUri.getPort() == clientRedirectUri.getPort()) {
return true;
}
}
return false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URI 여러개를 함께 등록할 수 있겠네요 👍

Copy link
Collaborator

@Starlight258 Starlight258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FacerAin FacerAin merged commit 38c7bd0 into dev Feb 19, 2024
2 checks passed
@Starlight258 Starlight258 deleted the feat/oauth-redirect branch March 18, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants