Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat#65] 안건 순서 수정 기능 개발 #66

Merged
merged 3 commits into from
Feb 21, 2024
Merged

[Feat#65] 안건 순서 수정 기능 개발 #66

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe854e8
[#65] feat: Add changeAgendaOrder
FacerAin Feb 20, 2024
88dcac3
[#65] feat: Fix changeAgendaOrder for verify agendaIds size
FacerAin Feb 20, 2024
85ea8e8
Merge branch 'dev' into feat/agenda-order
Starlight258 Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/dnd/timeet/agenda/application/AgendaService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,11 @@ public AgendaInfoResponse changeAgendaOrder(Long meetingId, List<Long> agendaIds
Collections.singletonMap("MeetingId", "Meeting not found")));
List<Agenda> agendaList = agendaRepository.findByMeetingId(meetingId);

if (agendaList.size() != agendaIds.size()) {
throw new BadRequestError(BadRequestError.ErrorCode.VALIDATION_FAILED,
Collections.singletonMap("AgendaIds", "Agenda Ids size is not matched"));
}
Comment on lines +177 to +180
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외 처리 다 잘 진행되었네요 :)


if (agendaList.size() != agendaIds.stream().distinct().count()) {
throw new BadRequestError(BadRequestError.ErrorCode.VALIDATION_FAILED,
Collections.singletonMap("AgendaIds", "Agenda Ids are not unique"));
Expand Down
Loading