Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/#-] CORS 에러 수정을 위해 allowed origin 추가 #71

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[Fix/#-] CORS 에러 수정을 위해 allowed origin 추가 #71

merged 1 commit into from
Feb 21, 2024

Conversation

Starlight258
Copy link
Collaborator

🔗 Linked Issue

🛠 개발 기능

  • CORS 에러 수정을 위해 allowed origin 추가했습니다.

🔍 리뷰 포인트

  • 후에 프론트 배포 url은 설정 파일 값으로 대체하면 좋을 듯 합니다.

📋 Code Review Priority Guideline

  • 🚨 P1: Request Change
    • 필수 반영: 꼭 반영해주시고, 적극적으로 고려해주세요 (수용 혹은 토론).
  • 💬 P2: Comment
    • 권장 반영: 웬만하면 반영해주세요.
  • 👍 P3: Approve
    • 선택 반영: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다.

@Starlight258 Starlight258 added this to the Sprint 4 milestone Feb 21, 2024
@Starlight258 Starlight258 self-assigned this Feb 21, 2024
FacerAin
FacerAin approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@FacerAin FacerAin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Starlight258 Starlight258 merged commit 570f471 into dev Feb 21, 2024
1 check passed
@Starlight258 Starlight258 deleted the feat/debug branch March 18, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FacerAin FacerAin FacerAin approved these changes

Assignees

@Starlight258 Starlight258

Labels
🚩 Priority: High 🐛 Type: Bug
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.
2 participants
@Starlight258 @FacerAin